[Freeciv-Dev] Re: [Patch] for to players_iterate

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: > 
> The attached patch replaces loops like
> 
>   for(i=0; i<game.nplayers; i++)
> 
> with players_iterate. 90% are straightforward. Can somebody look at
> the change of ai_manage_diplomat? Especially what 
> 
>    if (!ctarget && aplayer) {
> 
> should mean? The loop in handle_unit_enter_city and one in

The use of aplayer seems severely wrong to me.
Tony wrote it, ask him, but I think you are doing the right thing.


As for the other issues, could you split your patch please (into
stratightforward and structural changes).
I don't want to spend hours trying to find the few real changes in the sea of
straightforward ones.

G.

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com