[Freeciv-Dev] Re: [Patch] Cleanup can_establish_trade_route

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Feb 11, 2002 at 04:25:27PM -0500, Jason Short wrote:
> Raimar Falke wrote:
> > The original implementation used an hack (which made splint unhappy)
> > to test for existing traderoutes. The new version is cleaner.
> > 
> > Please review.
> I agree with Gregory - this is a significant improvement.
> 
> Instead of tracking used1 and used2, why not track free1 and free2 (the 
> number of free trade slots)?  Then the constant "4" (MAX_NUM_TRADEROUTS) 
>   will have less of an effect.

So this will reduce the occurrence of "4" from 3 to 1?!

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The BeOS takes the best features from the major operating systems. 
  It's got the power and flexibility of Unix, the interface and ease 
  of use of the MacOS, and Minesweeper from Windows."