[Freeciv-Dev] Re: [Patch] Cleanup can_establish_trade_route
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Raimar Falke wrote:
The original implementation used an hack (which made splint unhappy)
to test for existing traderoutes. The new version is cleaner.
Please review.
I agree with Gregory - this is a significant improvement.
Instead of tracking used1 and used2, why not track free1 and free2 (the
number of free trade slots)? Then the constant "4" (MAX_NUM_TRADEROUTS)
will have less of an effect.
jason
|
|
