Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2002:
[Freeciv-Dev] Re: [PATCH] convert save_options() to secfile (PR#1097)
Home

[Freeciv-Dev] Re: [PATCH] convert save_options() to secfile (PR#1097)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] convert save_options() to secfile (PR#1097)
From: Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>
Date: Wed, 16 Jan 2002 00:25:42 -0600

On Tue, Jan 15, 2002 at 11:44:21PM +0100, Reinier Post wrote:
> On Thu, Dec 06, 2001 at 05:20:40PM -0800, Mike Kaufman wrote:
> > here's another patch...
> > 
> > currently the client uses fprintf() to put options into .civclientrc
> > this patch changes this to secfile_insert_* etc, and does away with 
> > open_option_file() to boot.
> 
> What about backward compatibility?
> Apart from that it's great.

What it doesn't do, (as has been pointed out) is add comments is a nice 
manner, though you can do it. And since comments are stripped out
anyway, it's backwards compatible.

instead of:

message_where_00=3  # Low Funds

you get:

# 0=== Low Funds ===0
message_where_00=3


If you've tried CMA 3.0 or 3.1, you've used this patch.

I do not yet have the kahunas necessary to add a
secfile_insert_comment() to the registry. I would welcome anyone to do
so. It'd be nice to be able to place a comment _after_ a setting instead
of it's own line...

-mike


[Prev in Thread] Current Thread [Next in Thread]