[Freeciv-Dev] Re: PATCHES: AI cleanups (PR#1176)

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx> wrote:
>  --- Raahul Kumar <raahul_da_man@xxxxxxxxx> wrote: 
> > 
> > Eek. I thought I fixed that. Thanks for the save G. By the way, the
> > reason I did not employ igter_speedup was that a certain someone 
> > suggested sending
> > in unit_move_turns by itself. The igter stuff is a patch by itself,
> > when that is accepted I will go ahead and change move_rate *= to 
> > igter_speedup.
> 
> Yes I know, I gave more or less conflicting requests :(
> 
> But the line 
> 
> if (igter) move_rate *= SINGLE_MOVE
> 
> is plain WRONG, much worse than 
> 
> if (igter) move_rate *= 3;
> 
> Just imagine what happens if somebody changes SINGLE_MOVE...
> 
> So I just wouldn't want your patches to be potentially buggy, just write
> if (igter) move_rate *= (SINLGE_MOVE/MOVE_COST_ROAD)
> 
> And later when you introduce IGTER_SPEEDUP you can change this line
> again.
> 
> 
> And the comment should go to the place where you define IGTER_SPEEDUP,
> that would be the best, I feel.
> 
> > So for now I will just add some lines as comment
> > 
> > // FIXME: IGTER units should have their move rates multiplied by
> > igter_speedup
> > // Note: actually, igter units should never have their move rates
> > multiplied.
> > // The correct behaviour is to have every tile they cross cost 1/3 of a
> > movement
> > // point.
> > 
> > Good comment? No, the comments in the code will not be C++ style, I
> > just
> > happen to like that style.
> 
> I agree it is nice.
> 
> G.
> 
> 

Ok, I am resending the patch with 3 instead of SINGLE_MOVE. I don't think it
really matters that much, I'll be getting rid of it anyway with my next igter
patch. The comments I just added is only for the moment. That comment will be
moved to the correct spot by the igter patch(which will also get rid of the
3 I just added again).

I wes hoping for some comments on the correct warmap behaviour. You seem to
have
decided that the current method of multiplying the move rate of igter units by
3
is better than 1/3 move costs per tile. I'd just like to know your reasons for
that decision.






__________________________________________________
Do You Yahoo!?
Send your FREE holiday greetings online!
http://greetings.yahoo.com

unit_move_turns.diff
Description: unit_move_turns.diff