Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2001:
[Freeciv-Dev] [Patch] Tech cleanup
Home

[Freeciv-Dev] [Patch] Tech cleanup

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] [Patch] Tech cleanup
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 18 Dec 2001 22:34:49 +0100
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

While I made a final pass over the cost style patch I encountered same
problems: the naming and documentation of some tech related fields and
functions is just plain wrong (int researchpoints; /* # bulbs to
complete */) or misleading (tech_turns, calculate_tech_turns). This
makes it hard to understand the changes the cost style patch mades.

The attached patch:
 - renames fields, functions and variables
 - changes some types (mostly for common/tech)
 - adds docu

The patch doesn't change behavior. Only gui-gtk is patched. The patch
is quite big.

Do you think such a patch is useful? Do you have any other suggestions
for the new names?

If this patch is applied to CVS I will update the cost style patch and
make another pass over it.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  What's nice about GUI is that you see what you manipulate.
  What's bad about GUI is that you can only manipulate what you see.

Attachment: tech_cleanup1.diff.gz
Description: GNU Zip compressed data


[Prev in Thread] Current Thread [Next in Thread]