[Freeciv-Dev] Re: Buggy Diplomatic State (PR#1146)

[Jason Short <vze2zq63@xxxxxxxxxxx>]

Gregory Berkolaiko wrote:

> --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
>
> > On Tue, Dec 18, 2001 at 04:06:59PM +0000, Gregory Berkolaiko wrote:
> >
> > > Here is a fix.  Please test.
> > And what about the comment? Don't you think it has a purpose to stand
> > there?
> I rather suspect it _had_ a purpose.  See also comment in
> neutralize_ai_player.  Looks like complete nonsense to me, how rulesets
> can be affected by diplomatic state?
>
> My opinion: delete the lines and see what breaks.
> My bet: nothing breaks.
BTW: the patch works for me, too.  However, I am concerned about 
removing lines that claim to need to stay :-).
> Can you trace a particular line in CVS somehow?
"cvs annotate savegame.c"

This shows that these lines were introduced by Thue on January 4th, 
2001.  The CVS log says:
"Make a small modification to the savegame handling so that loading and
saving various parts of a game is conditional. This is usefull for a map
editor."

jason