[Freeciv-Dev] Voting results for second part of style guide questionnaire

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

Here are the results of the voting for the second part of style guide
(see attached questionnaire):

Petr Baudis
        10B  11B  12A  13D  14C
Petrus Viljoen
        10C  11B  12A  13E  14A
Sugih Jamin
        10A  11C  12A  13D  14C
Raimar Falke
        10C  11B  12?  13AEF 14D
Jason Short
        10BC 11B? 12A  13E  14C
Stepan Roh
        10C  11B  12A  13E  14B
Greg Wooledge
        10C  11A  12A  13D  14BC*
Daniel Sjölie
        10C  11D  12A  13D  14C
Julian Rüth
        10A  11B  12B  13F  14D
Justin Moore
        10CB 11B  12A  13AE 14B
Gregory Berkolaiko
        10B  11B  12?  13D  14C


Majory votes:
        10C  11B  12A  13DE 14C


If you can think of any other unresolved issues, communivate them to me,
please.

G.


=================================================================
/*******************
 * 10: long comments
 *******************/
int foo10(int x)
{

  /* A */
  /* blah
     blah blah
     blah */
  if (x == 0)
    return 1;

  /* B */
  /* blah
   * blah blah
   * blah */
  if (x == 1)
    return 0;

  /* C */
  /* 
   * blah
   * blah blah
   * blah 
   */
  return 42;
}


/**********************
 * 11: braces in switch
 **********************/
int foo11(int x)
{

  /* A (always braces) */
  switch (x) {
  case 2:
    {
      return 2;
    }
  case 3:
    {
      int d = 5;
      return d - x;
    }
  }

  /* B (braces where needed) */
  switch (x + 3) {
  case 2:
    return 2;
  case 3:
    {
      int d = 5;
      return d - x;
    }
  }

  /* C (no extra local variables) */

  {
    int d;
    switch (x) {
    case 2:
      return 2;
    case 3:
      d = 5;
      retrun d - x;
    }
  }

  /* D (all braces or no braces) */

}


/********************************
 * 12: empty lines between blocks 
 ********************************/
int foo(void)
{

  /* A */
  while (*i++) {
    ++j;
  }

  if (j > 10) {
    foo();
  }

  /* B */
  while (*i++) {
    ++j;
  }
  if (j > 10) {
    foo();
  }
}


/******************
 * 13: empty blocks 
 ******************/
int foo13(void)
{

  /* A */
  while (*i++) {
    continue;
  }

  /* B */
  while (*i++) {
  }

  /* C */
  /* while (*i++) {} 
   * is reduced to B by indent */

  /* D */
  while (*i++);

  /* E */
  while (*i++) {
    /* nothing */
  }

  /* F */
  /* !disallow such constructs! */
}


/******************************
 * 14: Comments in conditionals
 ******************************/
int foo14(void)
{
  int x = 0;

  /* A */
  if (is_barbarian(pplayer)) {
    x++;
    /* If not barbarian, ... */
  } else {
    x--;
  }

  /* B */
  if (is_barbarian(pplayer)) {
    x++;
  } else {                      /* If not barbarian, ... */
    x--;
  }

  /* C */
  if (is_barbarian(pplayer)) {
    x++;
  } else {
    /* If not barbarian, ... */
    x--;
  }

  /* D */
  if (is_barbarian(pplayer)) {
    x++;
  } else {                      /* if (is_barbarian(pplayer)) */
    x--;
  }
}



__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com