[Freeciv-Dev] Re: buglet in normalization in init_new_game() (PR#1063)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Nov 30, 2001 at 02:51:48PM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> 
> > Raimar Falke wrote:
> > 
> > 
> >>IMHO it looks like a job for a new circle_iterate.
> >>
> > 
> > The attached patch is an adequate implementation of circle_iterate
> > (actually, I'm not happy with the use of sqrt() but I'm not sure how to
> > do without it), 
> 
> 
> This is an updated patch that implements both square_dxy_iterate and 
> circle_iterate (which is a simple wrapper to square_dxy_iterate). 
> Hopefully this will make Gaute happy by providing the square_dxy_iterate 
> macro (which we both agree is useful).
> 
> I do think that circle_iterate should be a macro even if it's only used 
> once.  But I also think more uses will be found for it - as I explained 
> in my other patch.

> square_iterate could also be written as a macro to square_dxy_iterate, 

> but there might be an efficiency drop (not sure about this), so I 
> haven't done this.

I see no problem here.

Attached is an updated version which contains mostly style and comment
changes.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "Windows is the one true OS. MS invented the GUI. MS invented 
   the 32 bit OS. MS is open and standard. MS loves you. We have 
   always been at war with Oceana."

circle_iterate-3.diff
Description: Text document