[Freeciv-Dev] generalized unit capabilities
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
all,
here is a patch that provides a patch that extends the flag space of unit
capabilities. for lack of anything better to do all the document is in-code
using javadoc (so it will extract nicely :)
this patch basically extends the unit_flag from an enum to an array of
unsigneds. each index of the array contains a "category" where like flags are
grouped. category ids are found in the utype_category_id enum, the last value
of which defines the size of the array (CAT_LAST).
flags are redefined from enums to #defines (don't have to shift any more).
there's a documentation section at the bottom using doxygen that provides
space to actually document all the capabilities. i've only filled out some of
them.
this has been integrated into the ruleset configuration. i changed the
registry code to return 0 on a failed string lookup instead of exitting, and
then realized i was using the wrong lookup, but i forgot to take that fix
back out. it shouldn't really matter. exitting from within the parser is a
terrible form of error handling. i also didn't bother to change any of the
other lookups to test for that - net result will probably be a core dump if a
required configuration directive is missing. now that's good error handling -
it'll really let you know if you've messed up the ruleset :)
now, this code doesn't replace anything. the old flag structure is still
there because god knows what i'd break if i took it out. it also isn't
entirely complete. i only stuck a subset of total capabilities in there
because there's some stuff that wasn't documented too well.
so, here's the basic plan. take a look. if you like it, keep it. if you don't
like it - think of something better.
andy
- [Freeciv-Dev] generalized unit capabilities,
Andrew Sutton <=
- [Freeciv-Dev] Re: generalized unit capabilities, Raimar Falke, 2001/12/05
- [Freeciv-Dev] Re: generalized unit capabilities, Andrew Sutton, 2001/12/05
- [Freeciv-Dev] Re: generalized unit capabilities, Raimar Falke, 2001/12/05
- [Freeciv-Dev] Re: generalized unit capabilities, Andrew Sutton, 2001/12/05
- [Freeciv-Dev] Re: generalized unit capabilities, Raimar Falke, 2001/12/05
- [Freeciv-Dev] Re: generalized unit capabilities, Andrew Sutton, 2001/12/05
- [Freeciv-Dev] Re: generalized unit capabilities, Raimar Falke, 2001/12/05
- [Freeciv-Dev] Re: generalized unit capabilities, Vasco Alexandre Da Silva Costa, 2001/12/05
- [Freeciv-Dev] Re: generalized unit capabilities, Jason Short, 2001/12/05
- [Freeciv-Dev] Re: generalized unit capabilities, Andrew Sutton, 2001/12/05
|
|