[Freeciv-Dev] Re: AI cleanup - first wave

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Nov 30, 2001 at 05:58:04PM -0500, vze2zq63@xxxxxxxxxxx wrote:
> Raimar Falke wrote:
> 
> > On Fri, Nov 30, 2001 at 08:58:55PM +0100, Petr Baudis wrote:
> 
> > I think a requirement should be that someone else go through the
> > patches
> 
> 
> All at once, or as they are submitted?

This doesn't matter for me how the reviewers want it. I would like it
in smaller bits.

> > How are these changes related to the ongoing style
> > discussion?
> 
> 
> I imagine they're much more conformant than the current code, so that 
> shouldn't be much of an issue.
> 
> > I also noticed that you made changes which is the job of
> > indent. Like this
> > 
> > -    }
> > -    else {
> > +    } else {
> > 
> > Another time for the "feed all code through indent" discussion?!
> 

> Ugh.  I'm in favor of such a move (though I can certainly see its 
> drawbacks), but such discussions always result in much time spent and no 
> changes being made.  The question, really, is: is more time going to be 
> wasted figuring out code that indent mangles and working around the 
> annotate problems, or fixing code that indent could easily handle (like 
> in this case)?

Since I'm also in favor of this: what people are against it and what
patterns are known to be processed badly by indent?

> > As for the question you have asked: we should try one function at a
> > time and see how this works.
> 
> 
> The problem with this is that if each patch has a one-week lag time 
> before being commited it'll take way too long.  If you can handle a 
> one-day lagtime, then it should be reasonable.  (How many functions are 
> we talking about here, anyway?)

Make a queue (the tracking system) with one function per patch/entry
and we will see how fast the reviewers and the maintainers are.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 A life? Cool! Where can I download one?