[Freeciv-Dev] AI cleanup - first wave

[Petr Baudis <pasky@xxxxxxxxxxx>]

Hello,

  I want to tell you that I'm done with the possibly largest part of AI code
cleanup. Formatting changed, the code was heavily commented, some unused
functions were removed, some other were moved (still some queued) and the code
was simplified in few places. However the AI behaviour should remain same for
now, and it did according to my autogame tests.

  In which way I should feed you the patches? I have them in my private CVS
tree accessible thru cvsweb 
(http://pasky.ji.cz/cvsweb.cgi/freeciv/ai/?cvsroot=aiciv)
and if you want i have no problem with giving you direct access to the CVS
itself.  It would be maybe most convient for both you and me to get the patches
thru CVS (mostly one function == one commit), however some functions are
corrected by later revisions, so if you won't will to complete the correct
patches for those, i can do it. Also, if you are not willing to check the
changes out of my CVS, i can feed you with patches thru mail, but there will be
many of them and not everytime smallest ones (for large functions large
patches, i even had to split two additional functions from ai_eval_buildings()
as it was way tooo large).

  I would also like to ask others to review my version of AI and review it,
especially Tony to check my changes in his code ;-). Note that aiunit.c and
advmilitary.c are still mostly uncleaned (only patches I posted separately
before are commited), as I want to work those changes out together with Raahul.

Many thanks for comments,

-- 

                                Petr "Pasky" Baudis

UN*X programmer, UN*X administrator, hobbies = IPv6, IRC, FreeCiv hacking
.
  "A common mistake that people make, when trying to design
   something completely foolproof is to underestimate the
   ingenuity of complete fools."
     -- Douglas Adams in Mostly Harmless
.
Public PGP key, geekcode and stuff: http://pasky.ji.cz/~pasky/