Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: Documentation, Usability and Development

[Freeciv-Dev] Re: Documentation, Usability and Development

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Justin Moore <justin@xxxxxxxxxxx>
Cc: Freeciv Developers <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: Documentation, Usability and Development
From: Petr Baudis <pasky@xxxxxxxxxxx>
Date: Thu, 29 Nov 2001 23:36:01 +0100

> > Huge patches are bad idea, approval chance near zero, IMHO.
>    Yes, but in some cases they're the *only* way to do something.  If I'm
> ripping a 300 line function out of one file and creating a new one with
> that function in it, there is *no way* I can do that in less than 600
> lines.
If you are ripping a 300 line function, you should break it into pieces, as 300
may be a little too much (obviously depends on situation). And including it in
new one which will result in 600 lines of code looks even worse, this is imho
definitively a bad idea ;-).  I would make first patch which would rip the
function, second patch which would rip another function and third patch which
would create function merging those two by calling ripped bits of them ;-).

Obviously, there are some situations when making little patch is impossible.
However even if the patch is larger, it should always focus only on one
feature, not fixing/adding more things at once.

>         A patch should be the correction or improvement of one aspect or
> concept;


                                Petr "Pasky" Baudis

UN*X programmer, UN*X administrator, hobbies = IPv6, IRC, FreeCiv hacking
  "A common mistake that people make, when trying to design
   something completely foolproof is to underestimate the
   ingenuity of complete fools."
     -- Douglas Adams in Mostly Harmless
Public PGP key, geekcode and stuff:

[Prev in Thread] Current Thread [Next in Thread]