Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: [PATCH] base_real_map_distance (PR#1049)

[Freeciv-Dev] Re: [PATCH] base_real_map_distance (PR#1049)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Cc: bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] base_real_map_distance (PR#1049)
From: jdorje@xxxxxxxxxxxxxxxxxxxxx
Date: Tue, 27 Nov 2001 11:33:21 -0800 (PST)

Raimar Falke wrote:

On Sun, Nov 11, 2001 at 06:19:17PM +0100, Raimar Falke wrote:

On Thu, Nov 01, 2001 at 06:26:48AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:

This patch introduces a new topology function,
base_real_map_distance().  It performs a similar function to
real_map_distance, but also finds a distance vector from the source to
the destination coordinate pair.  It also replaces xdist and ydist.

A function like this is absolutely essential for iso-rectangular
topologies.  xdist() and ydist() will not work because you cannot find
the distance along one coordinate axis independently of the other.

I changed it a bit. Now real_map_distance, sq_map_distance and
map_distance follow all the same scheme.


And another one. Changes since last version:
 - change the range of dx in map_distance_vector and document the
 - add CHECK_MAP_POS to map_distance_vector
 - change the implementation of is_tiles_adjacent

Please review and comment.

Everything looks sane.  An external review would be nice.


[Prev in Thread] Current Thread [Next in Thread]