[Freeciv-Dev] Re: [PATCH] base_real_map_distance (PR#1049)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Nov 27, 2001 at 11:33:21AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> Raimar Falke wrote:
> 
> > On Sun, Nov 11, 2001 at 06:19:17PM +0100, Raimar Falke wrote:
> > 
> >>On Thu, Nov 01, 2001 at 06:26:48AM -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx 
> >>wrote:
> >>
> >>>This patch introduces a new topology function,
> >>>base_real_map_distance().  It performs a similar function to
> >>>real_map_distance, but also finds a distance vector from the source to
> >>>the destination coordinate pair.  It also replaces xdist and ydist.
> >>>
> >>>A function like this is absolutely essential for iso-rectangular
> >>>topologies.  xdist() and ydist() will not work because you cannot find
> >>>the distance along one coordinate axis independently of the other.
> >>>
> >>I changed it a bit. Now real_map_distance, sq_map_distance and
> >>map_distance follow all the same scheme.
> >>
> >>Comments?
> >>
> > 
> > And another one. Changes since last version:
> >  - change the range of dx in map_distance_vector and document the
> >  ranges
> >  - add CHECK_MAP_POS to map_distance_vector
> >  - change the implementation of is_tiles_adjacent
> > 
> > Please review and comment.
> 
> 
> Everything looks sane.  An external review would be nice.

Can somebody look at this code? Please.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
    1) Customers cause problems.
    2) Marketing is trying to create more customers.
  Therefore:
    3) Marketing is evil.