[Freeciv-Dev] Re: PATCH: map iteration (PR#1018)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Oct 23, 2001 at 09:24:00PM -0400, Ross W. Wetmore wrote:
> Whole_map_iterate() currently *guarantees* the map positions are all
> not only real, but normalized ... no checks are needed until you start
> to add new map types. I think Raimar just got carried away in his
> enthusiasm to bog doen the code with checks here.

All this stuff Justin is thinking about is preparation work for other
map types. This will reduce the size of the final patch which adds
other topologies.

> >My understanding is that whole_map_iterate also doesn't guarantee
> >anything about the order in which the coordinates are traversed.  The
> >stuff in server/savegame.c certainly needs such a guarantee.
> 
> This is true, but it is easily remedied by making a fixed order part of
> the interface, or providing versions that do have fixed orders.

It may be nice to have macros for this but I see for example no point
in providing a macro which is used two times in savegame.c. So we have
to do some kind of requirement analysis.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I haven't lost my mind - it's backed up on tape somewhere."