[Freeciv-Dev] Re: [Patch] dir_ok

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Jason Dorje Short <vze2zq63@xxxxxxxxxxx> wrote: 
> Gaute B Strokkenes wrote:
> > 
> > On Sat, 6 Oct 2001, hawk@xxxxxxxxxxxxxxxxxxxxxxx wrote:
> > > On Fri, Oct 05, 2001 at 10:59:37PM +0100, Gaute B Strokkenes wrote:
> > >> Did someone actually verify that this is a bug, as opposed to a
> > >> slightly unobvious implementation detail?
> > >
> > > AFAIK: no.
> > 
> > Then why are we changing it?
> 
> I'm pretty sure Thue said it was a mistake, and the final "return 0;"
> in
> the code that calls dir_ok should be a "return 1;".
> 
> In general, I believe it's being changed because it is not independent
> of the directional system (all those case statements...ugh).

Yes, Jason is right, the last return 0 in goto_zoc_ok is wrong.
As for dir_ok, don't worry too much about it, in my gotohand.c cleanup
process I removed it altogether ;) (and this is one of the more
non-controversial changes).

G.

____________________________________________________________
Do You Yahoo!?
Get your free @yahoo.co.uk address at http://mail.yahoo.co.uk
or your free @yahoo.ie address at http://mail.yahoo.ie