[Freeciv-Dev] Re: [Patch] dir_ok

[Jason Dorje Short <vze2zq63@xxxxxxxxxxx>]

Gaute B Strokkenes wrote:
> 
> On Sat, 6 Oct 2001, hawk@xxxxxxxxxxxxxxxxxxxxxxx wrote:
> > On Fri, Oct 05, 2001 at 10:59:37PM +0100, Gaute B Strokkenes wrote:
> >> On Fri, 5 Oct 2001, hawk@xxxxxxxxxxxxxxxxxxxxxxx wrote:
> >> >
> >> > Comments?
> >> >
> >> > I see not much point in verifying that savegames are equal since
> >> > the result is never used and the old code was buggy (allowed
> >> > orthogonal moves).
> >>
> >> Did someone actually verify that this is a bug, as opposed to a
> >> slightly unobvious implementation detail?
> >
> > AFAIK: no.
> 
> Then why are we changing it?

I'm pretty sure Thue said it was a mistake, and the final "return 0;" in
the code that calls dir_ok should be a "return 1;".

In general, I believe it's being changed because it is not independent
of the directional system (all those case statements...ugh).

jason