[Freeciv-Dev] Re: PATCH: remove map_adjuxt_[xy] invocations

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Oct 05, 2001 at 02:48:24AM -0400, Jason Dorje Short wrote:
> "Ross W. Wetmore" wrote:
> > 
> > I'm not sure what CHECK_MAP_POS() means today, but in the past I
> > didn't think it was testing this.
> > 
> > Of course I like is_normalized_map_pos() for consistency with current
> > code ... but we've been there too :-)
> > 
> > This is all going away, as soon as one passes normalized coordinates
> > as arguments, i.e. it is really only useful in these specific asserts.
> > 
> > So we should all let Boss Raimar have his way, and maybe he'll feel
> > better about the next request when it actually matters :-).
> 
> Except that now I've found a real use for is_normal_map_pos, so I
> strongly feel that we need that function.  Having CHECK_MAP_POS as a
> wrapper macro is fine.

You may have noticed that I haven't applied the CHECK_MAP_POS patch. I
agree with Jason that we found a user for is_normal_map_pos/
is_normalized_map_pos.

Part of the reason of CHECK_MAP_POS is that I tried to avoid the
naming issue.

I will make a is_normal_map_pos and change the CHECK_MAP_POS patch and
apply it.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Any sufficiently advanced technology is indistinguishable from magic."
    -- Arthur C. Clarke