[Freeciv-Dev] Re: PATCH: remove map_adjuxt_[xy] invocations

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

I'm not sure what CHECK_MAP_POS() means today, but in the past I
didn't think it was testing this.

Of course I like is_normalized_map_pos() for consistency with current
code ... but we've been there too :-)

This is all going away, as soon as one passes normalized coordinates
as arguments, i.e. it is really only useful in these specific asserts. 

So we should all let Boss Raimar have his way, and maybe he'll feel 
better about the next request when it actually matters :-).

Cheers,
RossW
=====

At 04:45 PM 01/10/03 -0400, Jason Dorje Short wrote:
>Raimar Falke wrote:
>> 
>> On Wed, Oct 03, 2001 at 01:03:08AM -0400, Jason Dorje Short wrote:
>> > [I tried to post this to freeciv-bugs much earlier today, but with still
>> > no success I think I've got some problem at my end.  Well, here it is.]
>> >
>> > The attached patch removes all remaining invocations of map_adjust_[xy]
>> > in server code.
>> >
>> 
>> > It has a bit of clutter, though: for one thing, it adds a function
>> > is_normal_map_pos, which may still be controversial.  I also think the
>> > assertions used in hmap, map_get_tile, and elsewhere would be better to
>> > put into map_inx (a question for later).
>> 
>> assert(is_normal_map_pos(x,y)) == CHECK_MAP_POS(x,y)
>
>Hmmm, we had this argument before.  I and (I think) a couple other
>people thought that asssert(is_normal...) is easier to read than
>CHECK_MAP_POS.
>
>What are other people's opinions?
>
>jason
>
>