[Freeciv-Dev] Re: PATCH: remove map_adjuxt_[xy] invocations

[Jason Dorje Short <vze2zq63@xxxxxxxxxxx>]

"Ross W. Wetmore" wrote:
> 
> I'm not sure what CHECK_MAP_POS() means today, but in the past I
> didn't think it was testing this.
> 
> Of course I like is_normalized_map_pos() for consistency with current
> code ... but we've been there too :-)
> 
> This is all going away, as soon as one passes normalized coordinates
> as arguments, i.e. it is really only useful in these specific asserts.
> 
> So we should all let Boss Raimar have his way, and maybe he'll feel
> better about the next request when it actually matters :-).

Except that now I've found a real use for is_normal_map_pos, so I
strongly feel that we need that function.  Having CHECK_MAP_POS as a
wrapper macro is fine.

jason