[Freeciv-Dev] Re: directional system: more magic code cleanups

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 12:25 PM 01/09/17 -0400, Jason Dorje Short wrote:
>Raimar Falke wrote:
>> On Mon, Sep 17, 2001 at 11:13:03AM +0100, Gregory Berkolaiko wrote:
>No, it must be positive (>0) rather than non-negative (>=0).  Traveling
>orthogonally to the destination is not OK.

It sort of depends on what your definition for this is. The current
definition is that the 3 directions that move you "further" away 
were not ok, but moving orthogonally, i.e. not getting any closer
was fine.

This freedom helps to navigate around some obstacles. And since there
is another function "find_shortest_direction", it is not unreasonable
to leave it this way.

>> > However Ross' patch might be more advanced than this.
>> 
>> No I don't think so ;)
>
>Ross's patch actually fixed the bug in straightest_direction, so it
>certainly was for that function.
>
>jason


Cheers,
RossW
=====