Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2001:
[Freeciv-Dev] Re: Fwd: Re: Re: Request (PR#939)
Home

[Freeciv-Dev] Re: Fwd: Re: Re: Request (PR#939)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Trent Piepho <xyzzy@xxxxxxxxxxxxx>
Cc: Paul Zastoupil <paulz@xxxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Fwd: Re: Re: Request (PR#939)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 7 Sep 2001 09:51:19 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Thu, Sep 06, 2001 at 10:30:31PM -0700, Trent Piepho wrote:
> On Thu, 6 Sep 2001, Paul Zastoupil wrote:
> > > 
> > > Why is it that you need to copy the string at all?  What's wrong with
> > > this?
> > > 
> > > static void wall(char *str) 
> > > { 
> > >   notify_conn_ex(&game.game_connections,-1,-1,E_MESSAGE_WALL, 
> > >                  _("Server Operator: %s"),str); 
> > > }
> > 
> > Well, I guess because we don't know that str is safe?
> 
> What do you mean, "safe"?  It's limited to the MAX_LEN_CMD.  I think you can
> assume that a function that takes a C string as an argument will get a C
> string.

$ grep -Ir MAX_LEN_CMD .
./ChangeLog:    MAX_CMD_LEN        -> MAX_LEN_CMD
$ grep -Ir MAX_CMD_LEN .
./ChangeLog:    MAX_CMD_LEN        -> MAX_LEN_CMD

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "At the beginning of the week, we sealed ten BSD programmers
  into a computer room with a single distribution of BSD Unix.
  Upon opening the room after seven days, we found all ten programmers 
  dead, clutching each other's throats, and thirteen new flavors of BSD."


[Prev in Thread] Current Thread [Next in Thread]