[Freeciv-Dev] Re: [PATCH] Corecleanup_07Part2 has been put in incoming

[Gaute B Strokkenes <gs234@xxxxxxxxx>]

On Sun, 2 Sep 2001, hawk@xxxxxxxxxxxxxxxxxxxxxxx wrote:
> On Sun, Sep 02, 2001 at 06:48:22PM +0200, Gaute B Strokkenes wrote:
>> On Sat, 01 Sep 2001, jshort@xxxxxxxxxxxxx wrote:
>> > Gaute B Strokkenes wrote:
>> >> 
>> >> On Thu, 30 Aug 2001, gs234@xxxxxxxxx wrote:
>> >> 
>> >> > When I get back from work I intend to change is_real_tile()
>> >> > IS_VALID_POS(), on the grounds that it tests a coordinate pair
>> >> > rather than a tile pointer, and because a position if valid
>> >> > iff it refers to a tile on the map.  I will change
>> >> > normalize_map_pos() to always adjust the x coordinate, and
>> >> > then I will add a IS_SANE_POS() to test whether a position
>> >> > refers to a tile on the map and is in canonical form.
>> >> 
>> >> And here it is.
>> > 
>> > The naming varieties here are really getting out of hand.
>> > 
>> > First of all, I think we all agree on using "map_pos" instead of
>> > "tile".  Perhaps "POS" would work instead, but why introduce it?
>> 
>> You seem to have been hypnotized by the recent discussion on the
>> topic.
>> 
>> I'm not introducing it.  The code is full of functions that end in
>> _pos without _map in front of it; normalize_map_pos() is the
>> anomaly.  It would make more sense to change normalize_map_pos to
>> normalize_pos, though personally it doesn't bother me too much.
> 
> The code contains bad things. We all agree on this. However we
> shouldn't continue to use bad stuff. Hopefully we can clean this and
> similar things up in the long term.

And why, pray tell, is bad with just "_pos" as opposed to "_map_pos" ?

I am sick and tired of debating every minor change.  A broad comment
like the above does not advance the discussion.  If anyone really
wants to go through the source and change all occurences of "_pos" to
"_map_pos" (a change that I would oppose, since I think it should be
the other way round) then they can do it afterwards.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
Should I start with the time I SWITCHED personalities with a BEATNIK
 hair stylist or my failure to refer five TEENAGERS to a good OCULIST?