[Freeciv-Dev] Re: [PATCH] Corecleanup_07Part2 has been put in incoming

[Jason Dorje Short <jshort@xxxxxxxxxxxxx>]

Gaute B Strokkenes wrote:
> 
> On Thu, 30 Aug 2001, gs234@xxxxxxxxx wrote:
> 
> > When I get back from work I intend to change is_real_tile()
> > IS_VALID_POS(), on the grounds that it tests a coordinate pair
> > rather than a tile pointer, and because a position if valid iff it
> > refers to a tile on the map.  I will change normalize_map_pos() to
> > always adjust the x coordinate, and then I will add a IS_SANE_POS()
> > to test whether a position refers to a tile on the map and is in
> > canonical form.
> 
> And here it is.

The naming varieties here are really getting out of hand.

First of all, I think we all agree on using "map_pos" instead of
"tile".  Perhaps "POS" would work instead, but why introduce it?  You
also use the "tile" naming immediately after you explained the other day
why it was wrong (and I agree with you).

You use VALID to mean the same thing as real, use SANE to mean the same
thing as normal/proper, then use real to mean the same thing as
normal/proper (in nearest_real_tile).

We've had this argument for so long that I don't think anyone really
cares about it anymore, but...at least lets be consistent with the
naming.  If we can't agree on anything else, let's go with "valid"
(instead of what is currently "real") and "proper" (instead of what is
currently "normal").  But lets change them all at once, and keep them
the same throughout.

jason