Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: [PATCH]refactor server/cityturn.c:city_build_stuff (PR 		Home

[Freeciv-Dev] Re: [PATCH]refactor server/cityturn.c:city_build_stuff (PR

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Arien Malec <arien_malec@xxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH]refactor server/cityturn.c:city_build_stuff (PR#917)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 29 Aug 2001 14:07:57 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx 
On Tue, Aug 28, 2001 at 02:43:45PM -0700, Arien Malec wrote:
> server/cityturn.c:city_build_stuff appears to be long and complicated, but
> actually has a very simple structure. The attached patch refactors
> city_build_stuff to uncover that structure, by splitting the main work into
> three sub functions.
> 
> This moves some ugliness off to city_build_unit and city_build_building
> functions are open for refactoring as well, but this patch cleans things up
> considerably, IMHO.

So you have only split these methods up? Any extra changes? It is hard
to tell from the diff.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "I haven't lost my mind - it's backed up on tape somewhere."
[Prev in Thread] Current Thread [Next in Thread]