[Freeciv-Dev] Re: duh

[Karl-Ingo Friese <kif@xxxxxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, 27 Aug 2001, Raimar Falke wrote:

> On Sat, Aug 25, 2001 at 04:29:38PM +0200, Raimar Falke wrote:
> > > > > > Here is an updated version. Please test.
> > > > > >
> > > > > > I have moved some of the code to an extra method and also
> > > > > > replaced the border drawing. However the latter one isn't needed
> > > > > > at all.
>
> So are there any comments on this one?
>

Hello Raimar,

back from weekend, I just took a short look at the diff. Even
while I did not test it out yet, it looks fine with me. Especialy
the new function to calculate the size of the flag helps to
understand the code better.

The 1-pixel black border you #defined out just changes the look.
I personaly liked the border for optical reasons; others (who
dislike it) could argue that it "wastes" information. But since
the last we all want is a "should flags have a 1 pixel border"
war I can absolutely live with that ;)

I'll have a closer look tomorrow when I have a more time.

Ingo

PS: There is a typo (mine): Please change the comment from
    "need to indexes" to "need two indexes"

-- 

Karl-Ingo Friese
kif@xxxxxxxxxxxxxxxxxxxxxxxxxx