[Freeciv-Dev] Re: duh

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Aug 27, 2001 at 03:26:18PM +0200, Karl-Ingo Friese wrote:
> On Mon, 27 Aug 2001, Raimar Falke wrote:
> 
> > On Sat, Aug 25, 2001 at 04:29:38PM +0200, Raimar Falke wrote:
> > > > > > > Here is an updated version. Please test.
> > > > > > >
> > > > > > > I have moved some of the code to an extra method and also
> > > > > > > replaced the border drawing. However the latter one isn't needed
> > > > > > > at all.
> >
> > So are there any comments on this one?
> >
> 
> Hello Raimar,
> 
> back from weekend, I just took a short look at the diff. Even
> while I did not test it out yet, it looks fine with me. Especialy
> the new function to calculate the size of the flag helps to
> understand the code better.
> 
> The 1-pixel black border you #defined out just changes the look.
> I personaly liked the border for optical reasons; others (who
> dislike it) could argue that it "wastes" information. But since
> the last we all want is a "should flags have a 1 pixel border"
> war I can absolutely live with that ;)

The flags have a one pixel wide border which is nicely scaled down for
me.

> PS: There is a typo (mine): Please change the comment from
>     "need to indexes" to "need two indexes"

I wondered about this one.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Transported to a surreal landscape, a young girl kills the first woman
  she meets and then teams up with three complete strangers to kill again."
    -- TV listing for the Wizard of Oz in the Marin Independent Journal