Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: [Patch] Cleanup regarding {city,unit}_owner
Home

[Freeciv-Dev] Re: [Patch] Cleanup regarding {city,unit}_owner

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [Patch] Cleanup regarding {city,unit}_owner
From: Trent Piepho <xyzzy@xxxxxxxxxxxxx>
Date: Fri, 24 Aug 2001 00:23:27 -0700 (PDT)

On Fri, 24 Aug 2001, Raimar Falke wrote:
>  4) after this if {unit,city}_owner() still takes to much time make a
>  macro/inline function out of it
>  5) if somebody sends me a patch for making owner field a pointer and
>  this is considerable faster than 4) I will apply it. In this patch
>  {unit,city}_owner() would probably end up as macros/inline functions
>  (but are still lower cased)

I thought you wanted to get rid of places id were used instead of pointers?

Why don't you make unit_x(), unit_y(), unit_homecity(), etc.  for every other
member of the structure?  Why is owner special?



[Prev in Thread] Current Thread [Next in Thread]