[Freeciv-Dev] Re: Passwd auth with MD5 hash

[Auth Gábor <franko@xxxxxxxxxxxxxxxx>]

Hi!

>> Advanced password auth patch for civserver. Enable password
>> authentication for clients, and passwords stored in MD5 hash.
> I don't see the md5 method.
  The hash is MD5, when salt begin $1$ magic chars, uses same call to
crypt().

>> +  char passwd[36];
> A symbolic define would be nice.
  Yes, it is not nice... :)

> You have to initialize Salt[0-11]. The access to Salt[12] is bad.
  Sorry, sorry...

>> +  sscanf(name, "%[^:]:%s",buf_name,buf_passwd);
>> +  if ( sscanf(req->name,"%[^:]:%s",buf_name,buf_passwd)!=2 )
> Could this be expressed with strchr()?
  Hmm... sscanf is not UNIX specified function, IMHO. This is declared
in stdio.h header.
-- 
Frank O'Yanco - Auth Gábor -=- Mobil/SMS +36203494743 /+36303687792
Age of The Penguin -=- SuSE Linux 7.1 -=- http://andromeda.rgstudio.hu