Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: inlining functions
Home

[Freeciv-Dev] Re: inlining functions

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Markus Linnala <maage@xxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: inlining functions
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 20 Aug 2001 14:32:37 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Mon, Aug 20, 2001 at 10:41:31AM +0300, Markus Linnala wrote:
> 
> I propose, we make configure option --use-inline.
> 
> If you have this option, we do something like:
> 
> #if USE_INLINE
> #define INLINE static inline
> #else
> #define INLINE
> #endif
> 
> And also if we are using gcc, add compiler option -Winline
> 
> Then we need to find out what functions to inline. I think you
> can have reasonable information by profiling.

This is all nice. I hope however that we can beat most of the things
by smarter planning of data structures/data handling and not macros
and inlining. So it like your spotting of get_player and also the
ongoing discussion about the map normalization. All this will just
elimate the calls and not make them faster.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Make it idiot-proof and someone will make a better idiot."


[Prev in Thread] Current Thread [Next in Thread]