[Freeciv-Dev] Re: Buglet.

[Gaute B Strokkenes <gs234@xxxxxxxxxxxxxxxx>]

On Fri, 10 Aug 2001, Thue wrote:

>On Friday 10 August 2001 01:34, Gaute B Strokkenes wrote:
>> There seems to be a bug in tile_move_cost_ai() map.c.  I think the
>> right half of the assertion on line 977 should be y < map.ysize,
>> rather than y <= map.ysize.  Or?  If this is intentional, I think it
>> is sufficiently non-obvious that someone who knows this part of the
>> code should add a comment.  Otherwise, we should replace the line
>> with `assert(is_real_tile(x, y);'.
>
>It should an "assert(is_real_tile(x, y);". But tracing the x,y args
>means going through most of the source. Could we wait until just after
>1.12.0 for fixing this? (It seems to work as it is...)

Sure.  The code is just a bit too permissive.  I thought this might be
intentional because you might have to worry about crossing the edge of
the map or something.

-- 
Big Gaute (not to be confused with LG)
Mit der Dummheit kämpfen Götter selbst vergebens.