Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: Buglet.
Home

[Freeciv-Dev] Re: Buglet.

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Gaute B Strokkenes <gs234@xxxxxxxxx>, freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Buglet.
From: Thue <thue@xxxxxxx>
Date: Fri, 10 Aug 2001 11:26:00 +0200

On Friday 10 August 2001 01:34, Gaute B Strokkenes wrote:
> There seems to be a bug in tile_move_cost_ai() map.c.  I think the
> right half of the assertion on line 977 should be y < map.ysize,
> rather than y <= map.ysize.  Or?  If this is intentional, I think it
> is sufficiently non-obvious that someone who knows this part of the
> code should add a comment.  Otherwise, we should replace the line
> with `assert(is_real_tile(x, y);'.

It should an "assert(is_real_tile(x, y);". But tracing the x,y args 
means going through most of the source. Could we wait until just after 
1.12.0 for fixing this? (It seems to work as it is...)

-Thue


[Prev in Thread] Current Thread [Next in Thread]