[Freeciv-Dev] Re: Cleaning up configure.in

[Thue <thue@xxxxxxx>]

On Sunday 17 June 2001 14:49, Jeff Mallatt wrote:
> At 2001/06/17 08:23 , you wrote:
> >On Sunday 17 June 2001 13:18, Thue wrote:
> >> On Sunday 17 June 2001 03:52, Vasco Alexandre Da Silva Costa wrote:
> >> > On Sun, 17 Jun 2001, Vasco Alexandre Da Silva Costa wrote:
> >> > > On Sat, 16 Jun 2001, David Pfitzner wrote:
> >> > > > Thue <thue@xxxxxxx> wrote:
> >> > > > > In the quest to make autoconf 2.50 work I have replaced the use
> >> > > > > of FC_CHECK_X_LIB with AC_CHECK_LIB.
> >> > > >
> >> > > > So I'd be concerned about changing this without either some
> >> > > > reasonable understanding of the details (which I don't remember),
> >> > > > or fairly widespread testing...
> >> >
> >> > I found the relevant email at last...
> >> > (http://arch.freeciv.org/freeciv-dev-199811/msg00194.html)
> >> >
> >> > ---
> >> > VASC @ IST
> >>
> >> This one and it's reply seem to be relevant
> >> http://sources.redhat.com/ml/autoconf/1999-01/msg00009.html
> >>
> >> But there are 500 lines of ugly shell/autoconf code in freeciv to do the
> >> completely standard thing of detecting X. It must be possible to do it
> >> better!
> >>
> >> -Thue
> >
> >Compared to the 500 lines for the xaw client this is the code for the gtk
> >client :)
> >-----------
> >    AM_PATH_GTK(1.2.1, gtk_found="yes", gtk_found="", imlib_found="")
> >    if test "x$gtk_found" = "xyes"; then
> >      AM_PATH_GDK_IMLIB(1.9.2, imlib_found="yes", imlib_found="")
> >      if test "x$imlib_found" = "xyes"; then
> >        CLIENT_CFLAGS="$GDK_IMLIB_CFLAGS"
> >        CLIENT_LIBS="$GDK_IMLIB_LIBS"
> >     found_client=yes
> >      fi
> >    fi
> >-----------
> >Ideally the xaw client configure code should be of the same size... I see
> > no reason why it shouldn't be possible.
> >I have looked around on the web, and I can't seem to find any such
> > macro...
>
> There are many vagaries about detecting X and its many different bahaviors.
>  Like David, I'd worry about making changes without really understanding
> their ramifications.  Most of the weird stuff is so that it will work on as
> many platforms as possible -- just getting it to work on one platform isn't
> really sufficient.
>
> jjm

Yes, I see the point and agree.

-Thue