[Freeciv-Dev] Re: [PATCH] _final_ *snprintf cleanup. (PR#774)

[Thue <thue@xxxxxxx>]

On Thursday 14 June 2001 00:00, Gaute B Strokkenes wrote:
> On Wed, 13 Jun 2001, thue@xxxxxxx wrote:
> > Just a quick look:
> > 1) this patch doesn't apply very cleanly
>
> Um, sure it does:
>
>   gs234@kern:~/freeciv$ patch -p0 < vsnprintf_final.diff
>   patching file `acinclude.m4'
>   patching file `configure.in'
>   patching file `common/Makefile.in'
>   patching file `common/ioz.c'
>   patching file `common/support.c'
>   patching file `server/report.c'
>   patching file `server/stdinhand.c'
>
> I took great care to remove all generated files before making the
> diff.  Or did you mean something else?

Umm, sorry, I was typing in the wrong path when trying to get patch to at the 
diff.

> > 2) running your command gives me:
> > bash-2.05$ aclocal && autoheader && automake && autoconf
> > /usr/bin/autoheader2.13: eval: line 98: unexpected EOF while looking for
> > matching ``'
> > /usr/bin/autoheader2.13: eval: line 112: syntax error: unexpected end of
> > file
>
> This doesn't happen for me, neither with nor without the patch.  I
> have a memory of seeing this message some time in the distant past,
> however.  (Perhaps automake and/or autoconf ought to be run before
> autoheader?)

Actually this is probably because I have version 2.50 of autoconf, and so not 
introduced by your patch...

-Thue