[Freeciv-Dev] Re: i18n, gettext
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Hi,
> I have worked a bit on the win32 gettext problem. Now I'm not changing
> the intl dir.
> A patch is attached. Do
>
> mv amiga/gettext.c common
> mv amiga/libintl.h common
I do not like your patch much. There are too much #ifdefs, which can
easyly be avoided. Please move all the system dependendant stuff into a
function (maybe called getsystemlocale()). The #ifdef for this can
include all globals and includes also!
Ciao
____ _ _ ____ _ _ _ _ ____
| | | | | | \ / | | | the cool Gremlin from Bischofswerda
| __ | ____| | \/ | | | WWW: http://www.dstoecker.de/
| | | | | | | | PGP key available on www page.
|____| _|_ |____| _|_ _|_ |____| I hope AMIGA never stops making fun!
|
|