[Freeciv-Dev] Re: [RFC] New event handling

[David Pfitzner <dwpfitzner@xxxxxxxxx>]

Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 

> The client will prepare the arguments, retrieve the localized format
> string and will vsnprintf it. There has to be some va_list magic.

I would suggest not using vsnprintf, but doing it "manually",
which shouldn't be too hard since there should only by %d and %s
and %% fields?  Oh, and %$2s or however that goes.  

That way you avoid va_list hassles, and can verify everything 
as you go, which otherwise you would have to do anyway before
calling vsnprintf() (since should not pass untrusted strings
and args to vsnprintf()).

-- David


__________________________________________________
Do You Yahoo!?
Yahoo! Auctions - Buy the things you want at great prices. 
http://auctions.yahoo.com/