[Freeciv-Dev] Updated patch: Treaty checks

[Marko Lindqvist <caz@xxxxxxxxx>]

 Changes since last version:

 - fixed server segfault related to destruction of city
   which is already part of treaty.



 For more information about this patch, see what I wrote when I sent first
version:

 http://arch.freeciv.org/freeciv-dev-200008/msg00592.html

 I want to comment some parts of it:

> Also avoids one segfault (bug still exists in less fatal form)

 City id patch is another partial fix. Together these patches provide
complete fix.

>  I check most clauses only when player tries to accept treaty instead of
> time clause is first time proposed. This may seem like not very

 Some things might change while clause is already in treaty. This means we
have to check clauses at the time player tries to accept it.

> user-friendly way of doing it. However, these checks should almost never
> fail unless either side have modified client (which allows setting
> illegal clauses in). Advantage of checking clauses only when accepting
> them is that in the future it's possible to make meeting not to reveal
> anything (s)he shouldn't know to other player.


 Caz

--

treaty_checks.diff
Description: Text document