[Freeciv-Dev] Patch: Reorganize revolution stuff

[Marko Lindqvist <caz@xxxxxxxxx>]

 This is still mostly untested and needs some cleanup, but I'd like to
hear some comments especially about that popup dialog.



 Player.revolution can now hold special values referring to phases
of revolution. Game.government_when_anarchy is no longer used to check
whether player is going through revolution. Instead these checks are based
solely on player.revolution.

 Some related changes:

  1. Player.revolution is now initialized.
  2. 'when_anarchy' can now be government type also otherwise available.
  3. Fixed bug(s) that even when 'Popup dialogs in AI mode' client option
     was set, government dialog never appeared for AI players.



 What 'Popup dialogs in AI mode' option is for? How should such dialogs
function?


 Caz

--

revolution_fix.diff
Description: Text document