[Freeciv-Dev] Re: viewing ai, allows you to control the ai (PR#535)

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Ronald van der Fange <fange@xxxxxxxxxx> wrote:

> Version: 1.11.4
> 
> When you view an AI you get full control of the actions, even when it is in
> ai-mode. I think this is a bug

I'm not sure this is strictly a bug, in the sense that its been like
this forever and maybe at one time it was intentional, but I agree
that in general its probably not desirable behaviour.

The attached patch (to current CVS) addresses this issue by extendng
the allowconnect server option regarding observers, and setting the
default so that AI connections are set to "observer" mode.  (Also
"dead" players, though probably doesn't actually matter in that case.)

This allows having the current behaviour by changing the allowconnect
option.  It doesn't work 100% since it only affects new connections -
if you aitoggle a connected human player, the connection will keep its
controller status.  Still, the patch should catch most "normal" cases.
(Would be possible to "fix" further, but at least for the easiest way
of doing so this would reduce flexibility, so not sure if worthwhile
or desirable.)

-- David

ai_observe.diff.gz
Description: GNU Zip compressed data