Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2000:
[Freeciv-Dev] Re: BUILT_SOURCES (PR#501)
Home

[Freeciv-Dev] Re: BUILT_SOURCES (PR#501)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: David Pfitzner <dwp@xxxxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: BUILT_SOURCES (PR#501)
From: gs234@xxxxxxxxx (Gaute (B) Strokkenes)
Date: 10 Aug 2000 03:03:05 +0200

David Pfitzner <dwp@xxxxxxxxxxxxxx> writes:

> On 09 Aug 2000 gs234@xxxxxxxxx (Gaute (B) Strokkenes) wrote:
> 
> > David Pfitzner <dwp@xxxxxxxxxxxxxx> writes:
> > 
> > Well, from my reading of the sources I thought that these files had to
> > be rebuilt whenever packets.c is changed.
> 
> Yes - manually.  Well, whenever you add a new send_packet_* function,
> which is not that often.
> 
> >  I thought that this was
> > probably just an oversight.  Adding them to BUILT_SOURCES would ensure
> > that this happens automagically whenever packets.c is changed.
> 
> I have trouble believing this - unless you also give automake some
> hints on how to build them!  Eg, how and when to run create_lsend.pl, 
> and how to know if the user has perl, etc.  That is, changing more 
> than just BUILT_SOURCES.  No doubt one _could_ do all this, but I 
> didn't consider it worth the work in this case.

Well, someone appears to have done most of the work for you.  From
aclocal.m4 in GNU fileutils:

Attachment: jm_PERL.m4
Description: Text document

Apart from that you'd need a target for packets_lsend.[ch], which
ought not to be a lot of trouble.

Off course, if the sort of change that would necessitate recreating
these files is pretty rare, then it's probably not worth it.  Would a
patch that adds comments to that effect in Makefile.am etc. be
welcome?

-- 
Big Gaute (not to be confused with LG)
Remember, if you try to ESCAPE, many APARTMENT HOPPING ALCOHOLICS will
 SIMONIZE your HALLWAYS!!  This is your LAST WARNING!!

[Prev in Thread] Current Thread [Next in Thread]