[Freeciv-Dev] Re: modify players_iterate macro? (PR#494)

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/08/05 23:52 , David Pfitzner wrote:
>Its about time that we had the players_iterate macro (added recently).
>Good, but...  
>
>I quite like the feature of the *_list_iterate macros that they 
>declare the loop variable for you, localised to the loop (with the 
>name specified by the caller).  It seems to me this is almost always 
>what one wants.  Any reason not to do this for players_iterate?  
>(patch attached).

I like this, too.

>(I guess this reasoning could apply to some of the other non-list 
>iterate macros too, but personally I can see myself using 
>players_iterate especially, so I have a selfish interest in that ;-)

It's also selfish to want to see all the places where players are iterated
to be changed to use the new iterator...  ;-)

jjm