[Freeciv-Dev] Re: Choose a Nation dialog disappearing (PR#482)

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/07/30 10:04 , Thue wrote:
>Den søn, 30 jul 2000 skrev Jeff Mallatt:
>> At 2000/07/30 09:51 , Thue wrote:
>> >Den tor, 27 jul 2000 skrev Thue:
>> >> Den tor, 27 jul 2000 skrev sroh7497@xxxxxxxxxxxxxxxxxxxxx:
>> >> > Full_Name: Stepan Roh
>> >> > Version: CVS 2000/07/27
>> >> > Distribution: Built from source
>> >> > Client: Gtk+
>> >> > OS: Linux
>> >> > Submission from: (NULL) (62.24.67.9)
>> >> > 
>> >> > 
>> >> > Try this:
>> >> > 
>> >> > Start a server
>> >> > Connect clients
>> >> > > start
>> >> > (at this point clients are choosing nation - don't choose,
>> >> > just let dialogs to be shown)
>> >> > > set timeout 60
>> >> > (at this point Choose a Nation dialogs disappears and clients are not
>> able
>> >> > to go on without disconnecting)
>> >> > 
>> >> > It doesn't depend on what is after 'set' command.
>> >> > 
>> >> > It was already in 1.11.4 and 1.11.0, but not in 1.10.0. I didn't
test it
>> >> > with Xaw client, because I have not it compiled.
>> >> 
>> >> The offending line is at 
>> >> http://www.freeciv.org/lxr/source/client/packhand.c#L707
>> >> I fail to see why that line should be neccesary.
>> >> (btw, the lxr needs an update)
>> >> 
>> >> -Thue
>> >
>> >I still can not see what this line should do. Anyone have any last insight
>> >before I delete it?
>> 
>> What line?  Line 707 seems utterly unrelated.
>> 
>> jjm
>
>The lxr source browser was updated since my mail; the line now is at 
>http://www.freeciv.org/lxr/source/client/packhand.c#L767

The direct cause is the addition of a call to send_game_info(0) in
set_command() in stdinhand.c.

This to me just feels like somethine that was hacked in to fix some obscure
bug.  Though I haven't come up with a scenario where this would be needed,
it may be better to conditionalize the send_game_info(0) on
server_state==RUN_GAME_STATE.  Attached is a patch.

pr482-0.diff
Description: Text document

jjm