Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2000:
[Freeciv-Dev] Re: PATCH to FreeCiv CVS-Snapshot-Jul-19 		Home

[Freeciv-Dev] Re: PATCH to FreeCiv CVS-Snapshot-Jul-19

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: PATCH to FreeCiv CVS-Snapshot-Jul-19
From: Falk Hueffner <falk.hueffner@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: 23 Jul 2000 12:53:20 +0200 
Jeff Mallatt <jjm@xxxxxxxxxxxx> writes:

> -  int c = MAX(1, city_list_size(&pplayer->cities));
> +
> +  if((c = city_list_size(&pplayer->cities)) < 1)
> +    c = 1; /* using MAX would mean double invocation of city_list_size() */

It seems MAX is only being used for 'int' arguments currently, so we
should rather make it an inline function, I think.

        Falk
[Prev in Thread] Current Thread [Next in Thread]