[Freeciv-Dev] [PATCH] gui-gtk transient windows

[Dennis Bjorklund <dennisb@xxxxxxxxxxxxxx>]

The gtk gui does not set it's dialogs to transient which in many
window managers are required for correct behavior. I've made a patch
against 1.11.0. It's not the latest cvs but I hope it apply anyway.

Without this patch and the latest sawfish window manager the dialogs come
up with bad sizes and strange positions. You can turn of some stuff in
sawfish that makes it sort of work. But setting the dialogs to transient
is the right thing to do.

It's a problem for popup_unit_select_dialog() which are called from
different places and should have different parents set for it. In citydlg
it should not have toplevel as it's parent. But since the function is
called from here and there I don't change it now. One way to solve it is
to have an extra popup_unit_select_dialog() just for citydlg.

There is also some other problems with the gtk-gui that I might change in
the future. For example, some dialogs can not be closed with ESC.

I've just subscribed to this list and I don't know how you normaly
work. When I make patches where should I send. Of course, if I make more
pataches I'll make them against the cvs version. But what do I do with
the patches. Are there some official person taking care of the gtk code?

Also, I would rather have a gnome interface built with glade and created
with libglade. It's very easy to make such an interface but I'm not
volentering to do that work just yet. Maybe in the future. Is someone
working on that?

There might be more windows that I have not found and fixed in the code. I
saw the code for the first time three or for hours ago so I have not
looked through every file. But it seems to be working alright here.

Anyway, it's working much better then the 1.11.0 version.

/Dennis Björklund

freeciv_patch.txt
Description: Text document