[Freeciv-Dev] Re: Little patch to worklist and help build wonder

[rutger@xxxxxxxx]

On Sun, Jun 18, 2000 at 10:59:25AM -0400, Jeff Mallatt wrote:
> At 2000/06/13 02:15 , rutger@xxxxxxxx wrote:
> >
> >Help build wonder button (helpbuildwonder.diff):
> >
> >* 'help build wonder' button also displays shields left for wonder.
> >  Reason: with a lot of caravan's walking around, I have problems
> >  keeping track of the shields left for a wonder. For example, I don't 
> >  want to help with a wonder when the shields less then 10.
> 
> A couple of problems:
> 
> - You should use our non-overflowing versions of string functions:
>   - sz_strlcpy() rather than strcpy()
>   - sz_strlcat() rather than strcat()
>   - my_snprintf() rather than sprintf()
> 
> - You should internationalize your strings.

I didn't know about these ones (I just started after reading
freeciv_hackers_guide.txt which didn't mention these ones); changed
the patch.
 
> Also, you could use a single string to simplify the code, and simplify the
> translators' lives.  Just _("Help build _Wonder (%d to go)") [note the _()
> to internationalize the string].

The problem is there are 2 strings to display:
  Help build Wonder
and
  Help build Wonder (535 to go)

I thought it would be easier for translators to have less redundancy,
and so split the string in the translation (and paste them in FreeCiv).

Rutger.

-- 
Rutger Nijlunsing, rutger @ null.net ----------------------------- Linux! --
Don't BiCapitalize without extremely good reason: it messes up the natural
human-eyeball search order -- Your Friendly Neighborhood Archive Maintainers
+31-40 ----------------------------------------------------------- ^X^S^X^Cs

helpbuildwonder.diff
Description: Text document