[Freeciv-Dev] Re: [FreeCiv-Cvs] thue: Remove the restriction that the number of star... (PR#372)

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/05/18 11:27 , Thue Janus Kristensen wrote:
>On Thu, 18 May 2000, Jeff Mallatt wrote:
>> At 2000/05/17 18:37 , Thue Janus Kristensen wrote:
>> >On Wed, 17 May 2000, Jeff Mallatt wrote:
>> >> At 2000/05/17 09:41 , freeciv@xxxxxxxxxxxxxxxxxxx wrote:
>> >> >This is an automated notification of a change to freeciv cvs, 
>> >> >on Wed May 17 06:32:07 PDT 2000 = Wed May 17 13:32:07 2000 (GMT)
>> >> >by Thue Janus Kristensen <thue@xxxxxxx>
>> >> >
>> >> >---- Files affected:
>> >> >
>> >> >freeciv/server civserver.c gamehand.c maphand.c stdinhand.c
>> >> >
>> >> >---- Log message:
>> >> >
>> >> >Remove the restriction that the number of starting positions in a
scenario
>> >> >must be >= MAX_NUM_PLAYERS.
>> >> >This makes the scenarios work wotk CVS again after MAX_NUM_PLAYERS was
>> >> >increased from 14 to 30.
>> >> 
>> >> Well, actually this does not make scenarios work.  Try loading a
scenario,
>> >> and setting aifill to 20.
>> >> 
>> >> jjm
>> >
>> >Yes it does. It just reduces aifill to the number of starting positions,
>> >which I think is ok (at least intented). Works for me at least.
>> 
>> The prior code handled the case by generating random starting locations,
>> which to me is the right solution.
>> 
>> jjm
>
>Which prior code is that? I was not aware of it, and I can't find it now.
>(lxr link into 1.10 source appreciated).

http://www.freeciv.org/lxr/source/server/gamehand.c?v=1.10.0#L71

>btw, I don't think you should generate random start positions in a
>scenario...

I agree!  This is why the scenarios supplied with the Freeciv need to be
updated to include start positions for MAX_NUM_PLAYERS.

However, whether or not to allow random starts should be left as a decision
to the scenario designer.  Which is why we need to allow random starts in
the code.

jjm