[Freeciv-Dev] Re: Too few starts and MAX_NUM_PLAYERS (PR#364)

[Thue Janus Kristensen <thue@xxxxxxx>]

On Sun, 07 May 2000, Thue Janus Kristensen wrote:
> 
> On Sat, 06 May 2000, David Pfitzner wrote:
> > With sufficiently old savegames, or with the scenarios in
> > freeciv/data/scenario, cvs server fails to load with error:
> > 
> > 0: Too few starts 14 (need at least 30).
> > 
> > This is from server/maphand.c: map_startpos_load(), due to
> > recently increased MAX_NUM_PLAYERS.
> > 
> > Several things to fix:
> > 
> > - The provided scenarios should ideally have more starts, corresponding
> >   to the new nations.  (Would be nice to have named start positions, ie 
> >   with nation name, rather than numbered positions...)
> > 
> > - Should load old savegames and scenarios anyway, and limit the
> >   number of initial players if necessary, or whatever.  Current 
> >   behaviour is particularly silly for non-scenario savegames, since 
> >   there the start positions are not really needed and are just 
> >   historical anyway.
> > 
> > -- David
> 
> Trivial patch attached. It just accepts maps with too few starts
> (with a comment), filling in with default unused 0,0 starts.
> 
> How do you edit/create scenarios? (yes, I know it would be just as easy to
> just edit the text files to ad dthe extra empty starts, which I will
> do when I commit this patch)
> 
> -Thue

hmm; scenarious must have MAX_NUM_PLAYERS starts.
So my patch just creates 16 players at 0,0 in this case :). Well, lets
fill in some more starts then. Or maybe just modify it as you suggested.
I'll have a look at that tomorrow.

-Thue