Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2000:
[Freeciv-Dev] Re: Too few starts and MAX_NUM_PLAYERS (PR#364)
Home

[Freeciv-Dev] Re: Too few starts and MAX_NUM_PLAYERS (PR#364)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Cc: bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Too few starts and MAX_NUM_PLAYERS (PR#364)
From: Thue Janus Kristensen <thue@xxxxxxx>
Date: Sun, 7 May 2000 01:11:40 +0200

On Sat, 06 May 2000, David Pfitzner wrote:
> With sufficiently old savegames, or with the scenarios in
> freeciv/data/scenario, cvs server fails to load with error:
> 
> 0: Too few starts 14 (need at least 30).
> 
> This is from server/maphand.c: map_startpos_load(), due to
> recently increased MAX_NUM_PLAYERS.
> 
> Several things to fix:
> 
> - The provided scenarios should ideally have more starts, corresponding
>   to the new nations.  (Would be nice to have named start positions, ie 
>   with nation name, rather than numbered positions...)
> 
> - Should load old savegames and scenarios anyway, and limit the
>   number of initial players if necessary, or whatever.  Current 
>   behaviour is particularly silly for non-scenario savegames, since 
>   there the start positions are not really needed and are just 
>   historical anyway.
> 
> -- David

Trivial patch attached. It just accepts maps with too few starts
(with a comment), filling in with default unused 0,0 starts.

How do you edit/create scenarios? (yes, I know it would be just as easy to
just edit the text files to ad dthe extra empty starts, which I will
do when I commit this patch)

-Thue

Attachment: mappos.diff
Description: Text Data


[Prev in Thread] Current Thread [Next in Thread]