[Freeciv-Dev] Re: patch: hash.c (PR#318)

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Raimar Falke wrote:
> On Sat, Mar 18, 2000 at 10:36:25PM -0800, David Pfitzner wrote:

> > (Yes, maybe we should just use glib, but so long as we're not doing 
> > so...)
> 
> I'm not familar with this part of the code but are there any reasons for not
> using glib's implementation?

There are 2 aspects:

1. We could require that people have glib on their system, and then
we would just use glib's hash tables etc.  Since this imposes an 
extra requirement on users (at least those not using the Gtk+ client, 
who already must have glib) (including I assume systems such as Amiga, 
Mac, BeOS, native Win32?), its a tradeoff between how much advantage 
we would get from glib vs the inconvenience to some users.

2. We could try to extract parts of glib which we want.  The question
is how easy or difficult it would be to extract and adapt for freeciv's
purpose (eg, without dragging in a whole lot of extra stuff and 
effectively including a duplicated glib within freeciv).  Since 
registry.c already has most of a hashing implementation it seemed 
easier to use that, so I didn't look into the glib possibility, but 
others may wish to.

-- David